Prevent creation of on-chain invoices below the dust limit #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nicolas Dorier <nicolas.dorier@gmail.com>
|
Will fix the tests. |
0.000000012 BTC (whether rounded or not) is below the dust threshold, causing this test to fail.
Don't apply dust threshold conditional for topup invoices.
satwo
commented
Nov 11, 2021
| @@ -196,7 +196,7 @@ private string GetPaymentMethodName(BTCPayNetworkBase network) | |||
| var dust = txOut.GetDustThreshold(); | |||
| var amount = paymentMethod.Calculate().Due; | |||
|
|
|||
| if (amount < dust) | |||
| if (amount < dust && paymentMethod.ParentEntity.Type != InvoiceType.TopUp) | |||
There was a problem hiding this comment.
@NicolasDorier Would it be better to use here
&& paymentMethod.ParentEntity.Type == InvoiceType.Standard ?
There was a problem hiding this comment.
Cool, wasn't sure if there are more non-standard invoice types in the pipeline.
NicolasDorier
force-pushed
the
prevent-dust-onchain-payment
branch
from
471fef4
to
9e69393
Compare
|
Fixed the test, also extended the test to actually test the dust limit. |
NicolasDorier
added a commit
that referenced
this pull request
Nov 15, 2021
* Prevent creation of on-chain invoices below the dust limit Fixes #3071. * Apply suggestions from code review Co-authored-by: Nicolas Dorier <nicolas.dorier@gmail.com> * small fix * Fix selenium test 0.000000012 BTC (whether rounded or not) is below the dust threshold, causing this test to fail. * fix CanCreateTopupInvoices test Don't apply dust threshold conditional for topup invoices. * Fix test, and minor changes Co-authored-by: Nicolas Dorier <nicolas.dorier@gmail.com>
charleyforey
pushed a commit
to zeus-pay/btcpayserver
that referenced
this pull request
Jan 27, 2022
…ver#3082) * Prevent creation of on-chain invoices below the dust limit Fixes btcpayserver#3071. * Apply suggestions from code review Co-authored-by: Nicolas Dorier <nicolas.dorier@gmail.com> * small fix * Fix selenium test 0.000000012 BTC (whether rounded or not) is below the dust threshold, causing this test to fail. * fix CanCreateTopupInvoices test Don't apply dust threshold conditional for topup invoices. * Fix test, and minor changes Co-authored-by: Nicolas Dorier <nicolas.dorier@gmail.com>
zeus-pay
pushed a commit
to zeus-pay/btcpayserver
that referenced
this pull request
Feb 3, 2022
…ver#3082) * Prevent creation of on-chain invoices below the dust limit Fixes btcpayserver#3071. * Apply suggestions from code review Co-authored-by: Nicolas Dorier <nicolas.dorier@gmail.com> * small fix * Fix selenium test 0.000000012 BTC (whether rounded or not) is below the dust threshold, causing this test to fail. * fix CanCreateTopupInvoices test Don't apply dust threshold conditional for topup invoices. * Fix test, and minor changes Co-authored-by: Nicolas Dorier <nicolas.dorier@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3071.