Simple Invoice Detail View Cleanup #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why tests are failing. |
bolatovumar
reviewed
Nov 15, 2021
dennisreimann
approved these changes
Nov 15, 2021
bolatovumar
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just more minor changes in my audit of this view ... as minor as consistent paddings, moving the Product Information to the left column, icons, etc..
I opted to add a class to site.css to leverage in the table headers, and I figure @dennisreimann might have an opinion on this .. wasn't sure this was the smartest way to do this, happy to redo as needed.
Before:
After:
I'd like to do more to this view in the future, but for now, just a few patches.
Open to any additional things I might be missing here.