API: Add description hash to CreateLightningInvoiceRequest #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs to be passed through the API for LNbank to support LNURL.
dennisreimann
added
Lightning
Kukks
reviewed
Mar 17, 2022
Kukks
approved these changes
Mar 17, 2022
|
Is this supposed to work with c-lightning? When I try to use LNURL I get an error |
|
Oh boy... ElementsProject/lightning#5163 / ElementsProject/lightning#4705 (I should mention I used Phoenix to try the payment, see also ACINQ/phoenix#213) I think the key is to use the new |
|
^ not sure if this PR is really the culprit, so I created a separate issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be passed through the API for LNbank to support LNURL.