Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the store's default currency when creating entities #3585

Merged
merged 6 commits into from
Apr 11, 2022

Conversation

dennisreimann
Copy link
Member

Prefills the invoice/paymentrequest/pull payment creation forms currency inputs with the store's default currency.

Also cleans up an old code path we had for the invoice creation, in which the store was selectable. We don't offer that anymore and invoices are created explicitely for one store.

Closes #3581. Closes #3582.

@dennisreimann dennisreimann added Enhancement Improvements to an existing feature UI / UX Front-end issues, for front-end designers labels Mar 30, 2022
@dennisreimann dennisreimann force-pushed the default-currency branch 4 times, most recently from 22c250b to ce3b0a3 Compare April 6, 2022 07:38
@pavlenex
Copy link
Contributor

pavlenex commented Apr 8, 2022

Seems there are conflicts here we should resolve @dennisreimann because of the API test PR

@dennisreimann
Copy link
Member Author

Yes, I'll rebase my PRs.

Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@NicolasDorier NicolasDorier merged commit cd9a527 into btcpayserver:master Apr 11, 2022
@dennisreimann dennisreimann deleted the default-currency branch April 18, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvements to an existing feature UI / UX Front-end issues, for front-end designers
Projects
None yet
5 participants