Add label filter for onchain tx API endpoint #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolatovumar
commented
Apr 2, 2022
| @@ -197,6 +198,23 @@ public async Task<IActionResult> UnReserveOnChainWalletReceiveAddress(string sto | |||
| filteredFlatList.AddRange(txs.ReplacedTransactions.Transactions); | |||
| } | |||
|
|
|||
| if (labelFilter != null) | |||
There was a problem hiding this comment.
I'm not sure how to test this as there is currently no way to set the label through the API, only through the UI. Maybe if #3561 is merged in then I can use that to patch the transaction with a label and then test the filtering.
There was a problem hiding this comment.
Added test in c9366a2
bolatovumar
force-pushed
the
feat/onchain-tx-api-label-filter
branch
from
1dd3a45
to
c9366a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3587