Lightning: Link to services directly #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisreimann
added
Enhancement
dennisreimann
commented
Mar 31, 2022
Comment on lines
-85
to
+96
| string cookieFileContent = null; | ||
| bool isFake = false; | ||
| try | ||
| { | ||
| cookieFileContent = await System.IO.File.ReadAllTextAsync(connectionString.CookieFilePath); | ||
| isFake = connectionString.CookieFilePath == "fake"; | ||
| connectionString.CookieFilePath = null; | ||
| } | ||
| catch (Exception ex) | ||
| bool isFake = connectionString.CookieFilePath == "fake"; // Hacks for testing | ||
| string cookieFileContent = isFake ? "fake" : null; | ||
| if (!isFake) | ||
| { | ||
| throw new System.IO.FileNotFoundException("Cookie file path not found", ex); | ||
| try | ||
| { | ||
| cookieFileContent = await System.IO.File.ReadAllTextAsync(connectionString.CookieFilePath); | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
| throw new System.IO.FileNotFoundException("Cookie file path not found", ex); | ||
| } |
There was a problem hiding this comment.
This part skips the cookie file reading for the fake path. The Spark part below looked like this is ok, but it never reached that point, because there was always the FileNotFoundException being thrown.
Comment on lines
+14
to
+18
| "BTCPAY_BTCEXTERNALSPARK": "server=/spark/btc/;cookiefile=fake", | ||
| "BTCPAY_BTCEXTERNALCHARGE": "server=https://127.0.0.1:53280/mycharge/btc/;cookiefilepath=fake", | ||
| "BTCPAY_BTCEXTERNALRTL": "server=/rtl/api/authenticate/cookie;cookiefile=fake", | ||
| "BTCPAY_BTCEXTERNALTHUNDERHUB": "server=/thub/sso;cookiefile=fake", | ||
| "BTCPAY_EXTERNALSERVICES": "totoservice:totolink;Lightning Terminal:/lit/;", |
There was a problem hiding this comment.
Just adding these fake services for testing in dev mode.
bolatovumar
approved these changes
Apr 2, 2022
dennisreimann
force-pushed
the
ln-services
branch
from
1b5e6eb
to
48a57fa
Compare
|
Dead link check failure unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3552.