LNURL: Use Lightning description template in LNURL metadata #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisreimann
force-pushed
the
lnurl-metadata
branch
from
d794086
to
88e490f
Compare
Unifies the invoice description for the Lightning and LNURL payment methods and fixes btcpayserver#3634.
For consistency with the Lightning payment method. Closes btcpayserver#3655.
dennisreimann
force-pushed
the
lnurl-metadata
branch
from
efc1a0d
to
7831ba3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifies the invoice description for the Lightning and LNURL payment methods and fixes #3634.
#3655 brought up a similar topic. In efc1a0d I unified the LNURL meta data with the Lightning invoice meta data, so that individual POS item purchases can be tracked using the invoice meta data.
de47d3a adds an order ID for individual POS item purchases. This is so that it is consistent with the Crowdfund order IDs and it is also used in the previously mentioned commit.