Generic Forms

[Kukks]

This re-adds the custom forms support and reactors things considerable as there were many bugs.

Things to note:

• the form id is not exposed when using pos/payment request. The UI is shown under a specific route
• no tempdata usage.
• there were bugs where the form would be in a validated state on first view

[dennisreimann]

I'm still thinking about how to make it work with #4568 and have the store branding applied to the form whenever possible.

The form per se doesn't have the connection to a store, but as custom forms are set up per store, it would work for those cases. However, we still would need something like a parameter for the generic forms, which will be used most of the times.

It'd certainly be good to have that possibility, because otherwise the form as an intermediate step would miss the branding that the initial and checkout view have.

[Kukks]

All forms are attached to a store. There is a "public" property on custom forms, which lets you use them without apps/pay requests, but the hardcoded ones are always set to false. That means the form always has a stored available to it

[dennisreimann]

Added the branding aspect to the non-public forms and cleaned up the views a bit.

The test failures seem to be DB related, but at first glance I don't see what might be wrong … I cleaned up one field in the migration, but there are two errors remaining which look like they might be related to the recent blob changes — any idea @Kukks @NicolasDorier?

  Failed CanDoRateSourceMigration [7 s]
  Error Message:
   Npgsql.PostgresException : 42883: operator does not exist: text ->> unknown

POSITION: 220
  Stack Trace:
     at Npgsql.Internal.NpgsqlConnector.<ReadMessage>g__ReadMessageLong|215_0(NpgsqlConnector connector, Boolean async, DataRowLoadingMode dataRowLoadingMode, Boolean readingNotifications, Boolean isReadingPrependedMessage)

  Failed CanCreateSqlitedb [1 s]
  Error Message:
   System.NotSupportedException : SQLite does not support this migration operation ('AlterColumnOperation'). See http://go.microsoft.com/fwlink/?LinkId=723262 for more information.
  Stack Trace:
     at Microsoft.EntityFrameworkCore.Migrations.SqliteMigrationsSqlGenerator.Generate(AlterColumnOperation operation, IModel model, MigrationCommandListBuilder builder)

[dennisreimann]

tACK

[dennisreimann]

Added validation and adapted the validation styles to use the Bootstrap 5 classes :)

[NicolasDorier]

if id is null (as you did below), you should return null. Also make string id nullable. You are actually passing a null potentially in some controller.

[NicolasDorier]

I like the idea, though why is it called internal_?
Also maybe in later PR we can make this more generic such that the form can configure all fields of CreateInvoiceRequest.

[NicolasDorier]

I made a few minor observations, after it seems good to be merged.