Greenfield: Admins can create/delete API keys of any user #4680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeet
reviewed
Feb 22, 2023
| @@ -27,7 +27,47 @@ | |||
| }, | |||
| "security": [ | |||
| { | |||
| "API_Key": ["unrestricted"], | |||
| "API_Key": [ "unrestricted" ], | |||
There was a problem hiding this comment.
I see you introduced the canmanageuser permission. I wonder if it still needs to say unrestricted here or canmanageuser is enough now?
There was a problem hiding this comment.
This is different. This route is for the current user, so it has different permission.
The CanManageUser is a server policy, only available to admins.
You need unrestricted if you want to remove keys from the current user.
Note that unrestricted doesn't mean "admin". It means that the user need to have access to all permissions via unrestricted.
There was a problem hiding this comment.
Got it, thanks for the explanation.
Kukks
requested changes
Feb 22, 2023
Kukks
reviewed
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4675
Improved doc to close
Close #4673