POS: Align Keypad centered vertically #4690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the UI on Desktop and tablet. Closes btcpayserver#4682.
dennisreimann
added
Enhancement
|
Will take a look here shortly! Screenshots look great though. |
dstrukt
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
LGTM!
Awesome work on implementation @dennisreimann, really loving this POS.
I might explore removing the borders around the numbers as a variant to see if we like the way it looks more, still something I'm not 100% certain I love, but it's an easy enough adjustment we can explore when we get more feedback, and can easily address if/when we have to deal with the multi-step Tip functionality.
|
@pavlenex Can you also give this a final check? We can then merge and include it. |
pavlenex
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the UI on Desktop and tablet. Closes #4682.
Made it so that the space for the calculation and discount/tips UI is taken if they can appear potentially. This way the UI items don't change places if something (dis)appears.