Add currency code to payment request table #4709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasDorier
force-pushed
the
add-currency-code-to-payment-request-table
branch
from
c564d60
to
19cfd86
Compare
NicolasDorier
force-pushed
the
add-currency-code-to-payment-request-table
branch
from
19cfd86
to
470fc6c
Compare
|
I changed your PR to just add (USD) suffix. That said, your way of doing a new column is more in line with what we did in pull payments page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4619
Some currencies have exactly the same formatting even though their values are different. Showing them with exactly the same formatting can be misleading even though it's technically correct for each of these currencies.
Not sure what the best way of dealing with this is but adding a column with the currency code seems like the most straightforward way to deal with this even though the currency code display can be redundant in many cases.