Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet Transactions Export: Add BIP-329 support #4799

Merged
merged 6 commits into from Mar 27, 2023

Conversation

dennisreimann
Copy link
Member

@dennisreimann dennisreimann commented Mar 21, 2023

Adds support for the BIP 329 export format.

Sample transactions export:

{"type":"tx","ref":"9eb4b1f69dc0aad88f2530fdd124c77021c1633500e14369d0896bf75a025596","label":"microtransaction"}
{"type":"tx","ref":"98ee2e20e45967eeda330b191d881584d1e02ea05e633e4cb7c48aea8980fc63","label":"test"}
{"type":"tx","ref":"84ce8b198d85e715588da114b7b441833cfc4892ba9aa1f7f3cfbfdcf2ca1235","label":"Mining Income, microtransaction, test"}

Currently only the transaction data is exported, but I think we can also leverage the new labeling system to export other types, like addr as well. @NicolasDorier

Closes #4536.

grafik

@dennisreimann dennisreimann added Enhancement Improvements to an existing feature Wallet Related to internal BTCPay wallet labels Mar 21, 2023
@NicolasDorier
Copy link
Member

NicolasDorier commented Mar 22, 2023

Can I test it somewhere with another wallet? I believe you should also export the addresses. Me or @Kukks can add that to the PR after.

Also it should be Wallet Labels Export (BIP-329) rather than underscriptive JSON (bip-329) I believe.

@NicolasDorier
Copy link
Member

NicolasDorier commented Mar 23, 2023

I give up implementing address export for now.
I need to refactor the export stuff so we don't need another hack overload.

@dennisreimann dennisreimann marked this pull request as ready for review March 23, 2023 05:54
@NicolasDorier NicolasDorier merged commit c53d527 into btcpayserver:master Mar 27, 2023
1 check passed
@dennisreimann dennisreimann deleted the bip-329 branch March 27, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvements to an existing feature Wallet Related to internal BTCPay wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support BIP 329: Wallet Labels Export Format
4 participants