Lightning: Relax GetInfo constraint for LNDhub connections #5083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LNDhub-compatible implementation by LNbits does not support the `GetInfo` call for all their funding sources — see lnbits/lnbits#1182. By catching that exception in combination with the `LndHubLightningClient`, we give people the ability to still use their LNbits-based LNDhub as a Lightning node. Fixes btcpayserver#4482.
|
@dennisreimann A |
|
By |
Kukks
requested changes
Jun 19, 2023
|
Yup, I like the way that Nicolas suggested. Will update. |
dennisreimann
added a commit
to btcpayserver/BTCPayServer.Lightning
that referenced
this pull request
Jun 19, 2023
NicolasDorier
pushed a commit
to btcpayserver/BTCPayServer.Lightning
that referenced
this pull request
Jun 19, 2023
|
Updated it. Depending in the LNbits version, the endpoint is either not supported or returning incomplete data — both cases are handled now and lead to the node getting registered, but without public addresses.
/cc @callebtc |
1 task
|
Just to confirm that the setup that finally works is this one BTCPay Server v1.11.7+a921504bc LNBits ver 0.11.1 lndhub plugin 0.3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LNDhub-compatible implementation by LNbits does not support the
GetInfocall for all their funding sources — see lnbits/lnbits#1182. By catching that exception in combination with theLndHubLightningClient, we give people the ability to still use their LNbits-based LNDhub as a Lightning node.Talked about this with @Kukks and @callebtc at BTCPrague, because people keep asking for a workaround. Fixes #4482.