Checkout v2: Play sound when invoice is paid #5113
Conversation
dennisreimann
added
Enhancement
|
Is there a default sound? |
Not yet, if we intend to ship some, that's definitely possible, but I'd also leave the possibility tp upload a custom one as well. |
|
Sure yes, but I think we need to have a default sound, if we have a simple unique sound it can also become the part of the brand. I'm okay with having option for custom sounds. |
|
Agreed, we have the code part in place already — @dstrukt and @webwworthy can take over and come up with a btcpay'y sound 🎵 |
dennisreimann
force-pushed
the
payment-sound
branch
from
48eb34b
to
80876f1
Compare
|
When we have a default sound, we should use it for the "Retail preset" |
|
Pick up my commit NicolasDorier@f2a0347 |
dennisreimann
force-pushed
the
payment-sound
branch
from
f2a0347
to
af50d53
Compare
dennisreimann
force-pushed
the
payment-sound
branch
from
af50d53
to
c6cf18e
Compare
|
Integrated a default sound (to be replaced? ;)) and the option to customize it by uploading another sound file.
|
Enabled the default sound by default for new stores in both cases. |
|
Got a few ideas started for a default sound :) there are sound clips to listen too in the link below. While I was working on these I was wondering could if we give them a few default sounds to pick from? Maybe when you click the check box to play sound on payment a list of choices comes up inbetween the "play sound on payment" and custom file input? @dennisreimann @dstrukt @pavlenex 5x separate mp3's in this folder: |
|
Good work @webwworthy, personally I like the simplest one, "default sound bels". |
|
tbh I don't think there's an ideal one there yet. To me they seem to dry and imho we should have something a bit more cheerful, especially since this can be used with the confetti. My 2 sats …
We could, but imho it'd be good to have one iconic default sound. |
dennisreimann
force-pushed
the
payment-sound
branch
from
c6cf18e
to
d0adbb4
Compare
|
I am with @dennisreimann on having a default "iconic" sound. It could become a part of the brand! Also tend to agree about having something a tiny bit more cheerful, yet simple. @webwworthy any idea how we could make them a tiny bit happy sounds? |
|
for sure! @dennisreimann @pavlenex I can work on those to make some thing a bit brighter and more interesting. That is a good note to match the confetti, I will keep that in mind working on the next version 👍 |
|
I don't have stong opinion, but I believe by default the sounds should be off. And the retail preset should activate sound. |
|
@NicolasDorier I agree with that, not strongly but I think it's fair to have the sound only in retail mode by default, at least that allows us to test things out slowly, without scaring people with sounds online. ACK on my end for that approach, having a sound may not be expected when doing online shopping and if people like it, we can easily add it as a default on. |
|
@dennisreimann @pavlenex round 2 of default sounds to review, these still might not be one epic default sound yet and will keep working on them. https://drive.google.com/drive/folders/1f3Cg-dfyAaDniUSH6kNW_OkSa-y3WCCm?usp=sharing |
|
The forth one (horn + chime) is a bit too dark/oomphy imho, but it goes in a good direction. A version which is a bit more cheerful would be nice — maybe also a progression of two or three notes/chords. It could also be a bit longer, maybe aim for three seconds — to fit the start of the grafitti animation, which in whole takes about five seconds. |
|
There are two sounds that we need, and I am still with Nicolas that these need to be in retail mode.
I don't think these need to be too long but we can make if we want to. We can also just try to mimic what credit cards do it's very simple sounds just a sec or two indicating, success or failure. They just use simple beep. |
dennisreimann
force-pushed
the
payment-sound
branch
from
d0adbb4
to
f5b9c21
Compare
|
I made some new sounds and kept them simple this round. The sounds I like the most don't have the "_alt" extension. Those files are another option for each one. There is also a clip of all the runner-ups that are additional alternatives. Success, Error, NFC sounds are all in this folder: |
dennisreimann
force-pushed
the
payment-sound
branch
from
f5b9c21
to
ee521ac
Compare
|
I've now prepared everything so that only the sound files need to be changed to whatever gets chosen. The three files are located in the |
|
@pavlenex can you try this one and see if we can merge? |
Allows to play the sound regardless of browser permissions.
dennisreimann
force-pushed
the
payment-sound
branch
from
e8e7827
to
6b7cfa9
Compare
|
Updated the label wording to better indicate, that the setting enables all sounds, while the custom file is only for successful payments.
|
|
tACK for implementation. I haven't tested the NFC sounds but they're available. We still have to agree on the sounds, but @dennisreimann made it easy to replace these sounds so whoever takes over this par can easily do it, since Dennis will be afk. |
|
You'll for sure need to replace the default success sound 😂 |
|
@webwworthy It's up to you, I still kinda feel we need something very simple and mimic credit card payments. I would not use complicated coin sounds, it's just too much. Do you have any more ideas or should we vote on existing ones? To me suggested success sound is problematic, sounds more of an error to me, but could be just me? |
|
Here is a clip all of the simple success sounds I've made with out any coin sound effects: I think someone should choose one of those four choices. It doesn't have the be the end all be all default sound forever and there was a simple "bells only" clip you liked early on, that is the first sound in this new success sounds clip. My vote is the current success sound or other than that the "bells only" sound would be my preferred second choice for now. |
|
link to all 4 sounds as individual .mp3's: |
|
Success-1.Mp3 is dope! I vote for that one. |
Adds the option to upload an audio file that gets played once a payment is made. Closes #5085.