POS fixes #5228
Merged
POS fixes #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kukks
approved these changes
Aug 4, 2023
The recent fixes lead to some new regressions. This fixes btcpayserver#5224, fixes btcpayserver#5217, fixes btcpayserver#5213.
dennisreimann
force-pushed
the
pos-fixes
branch
from
f5bdec3
to
e52cdf9
Compare
Closed
1 task
|
Did you also try the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent fixes lead to some new regressions. This fixes #5224, fixes #5217, fixes #5213.
To ensure that this still fixes the original issues, I added some
"and'to the category names, titles and description tags, because those initially broke things. Can you give the fixes for the original issues a second look, @Kukks?