Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve invoices status filter #5248

Merged
merged 1 commit into from Aug 10, 2023
Merged

Conversation

dennisreimann
Copy link
Member

Adds filter for expired status and makes the Status and ExceptionStatus work non-exclusively, to make the search behaviour more intuitive. Before it wasn't possible to have invoices with an exception status in the list if it was also filtered by a regular status — now that works.

Fixes #5246.

Adds filter for expired status and makes the `Status` and `ExceptionStatus` work non-exclusively, to make the search behaviour more intuitive. Before it wasn't possible to have invoices with an exception status in the list if it was also filtered by a regular status — now that works.

Fixes btcpayserver#5246.
@ndeet
Copy link
Contributor

ndeet commented Aug 10, 2023

Holy moly, so quick, thank you 💚

Copy link
Member

@Kukks Kukks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test fail?

code ack

@petzsch
Copy link
Collaborator

petzsch commented Aug 10, 2023

1 Selenium Test fails according to CircleCI:

  Failed CanUsePayjoinViaUI [28 s]
  Error Message:
   OpenQA.Selenium.NoSuchElementException : no such element: Unable to locate element: {"method":"css selector","selector":".payment__details__instruction__open\-wallet__btn"}
  (Session info: headless chrome=101.0.4951.41)
  Stack Trace:
     at OpenQA.Selenium.WebDriver.UnpackAndThrowOnError(Response errorResponse)
   at OpenQA.Selenium.WebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebDriver.FindElement(String mechanism, String value)
   at OpenQA.Selenium.By.<.ctor>b__11_0(ISearchContext context)
   at OpenQA.Selenium.By.FindElement(ISearchContext context)
   at OpenQA.Selenium.WebDriver.FindElement(By by)
   at BTCPayServer.Tests.PayJoinTests.CanUsePayjoinViaUI() in /source/BTCPayServer.Tests/PayJoinTests.cs:line 314
--- End of stack trace from previous location ---

@dennisreimann
Copy link
Member Author

1 Selenium Test fails according to CircleCI:

Unrelated and potentially flaky test, re-running them …

@Kukks Kukks merged commit c0fc31c into btcpayserver:master Aug 10, 2023
4 checks passed
@dennisreimann dennisreimann deleted the fix-5246 branch August 10, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Invoices overview status filter issues
4 participants