Wallet Receive: Update address formatting #5313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kukks
approved these changes
Sep 11, 2023
|
Checking if I can't fix this small gap
|
|
What do you think of instead just truncating exactly the number of characters, and use a |
|
It is done this way to handle flexible width scenarios. Imho it's good enough and solves the problem – we're using this in most places for a while now and no one complained. 😀 |
dstrukt
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
tACK - LGTM!
Agree with @NicolasDorier on the minor nit of removing the extra space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5311.
Before
After