Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluginify BTCPayNetworkProvider #5331

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

NicolasDorier
Copy link
Member

@NicolasDorier NicolasDorier commented Sep 20, 2023

Summary

  1. This PR makes it possible for plugin to inject BTCPayNetwork.
  2. It also decouple the transaction link generation responsability out of BTCPayNetwork.
  3. Make it possible for plugins to override the configuration settings --chains by using SelectedChain.Add.
  4. Introduce PluginServiceCollection, a concrete type of IServiceCollection injected into plugins. This allow notably to get so called BootstrapServiceProvider which expose some services even before startup.
  5. --chains have a new settings *, which mean allow all the networks to be injected.
  6. End of support for dead altcoins
  7. Small refactor for the creation of the payment request viewmodel, we had some duplicated code

Decoupling of transaction link generation

This PR extract the transaction link generation out of the BTCPayNetwork class as an effort to break up dependencies to it.
Many more PR will need to follow to decouple the responsability of the "god class".

End of support for altcoins

Due to the heavy refactoring needed to support altcoins, I decided to remove alt those who are considered dead (no volume on exchange and more than top 1000).

  • Althash
  • Argoneum
  • Bitcoin Plus
  • Bitcore
  • Feathercoin
  • Polis
  • UFO
  • Viacoin

Those still interested in those coins will be able to pluginify them by themselves thanks to this PR.

@NicolasDorier NicolasDorier merged commit 04292d0 into btcpayserver:master Nov 29, 2023
2 of 4 checks passed
@NicolasDorier NicolasDorier deleted the qofibgbq branch November 29, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants