Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BTCPayNetwork
.BTCPayNetwork
.--chains
by usingSelectedChain.Add
.PluginServiceCollection
, a concrete type ofIServiceCollection
injected into plugins. This allow notably to get so calledBootstrapServiceProvider
which expose some services even before startup.--chains
have a new settings*
, which mean allow all the networks to be injected.Decoupling of transaction link generation
This PR extract the transaction link generation out of the
BTCPayNetwork
class as an effort to break up dependencies to it.Many more PR will need to follow to decouple the responsability of the "god class".
End of support for altcoins
Due to the heavy refactoring needed to support altcoins, I decided to remove alt those who are considered dead (no volume on exchange and more than top 1000).
Those still interested in those coins will be able to pluginify them by themselves thanks to this PR.