Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose linking Greenfield API information within the Legacy API view #5635

Merged
merged 7 commits into from Jan 3, 2024
Merged

Propose linking Greenfield API information within the Legacy API view #5635

merged 7 commits into from Jan 3, 2024

Conversation

hiluan
Copy link
Contributor

@hiluan hiluan commented Jan 2, 2024 •
edited by Kukks

This PR is a proposal for issue #5571: linking the Greenfield API view to the Legacy API view.

Screenshot 2024-01-01 203900

dennisreimann
dennisreimann reviewed Jan 2, 2024
View reviewed changes
Copy link
Member

@dennisreimann dennisreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition. I think we should also move that section to the top, so that users are drawn to the Greenfield API option, rather than using the legacy implementations.

BTCPayServer/Views/UIStores/ListTokens.cshtml Outdated Show resolved Hide resolved
@hiluan
Copy link
Contributor Author

hiluan commented Jan 2, 2024 •
edited

Thanks for the addition. I think we should also move that section to the top, so that users are drawn to the Greenfield API option, rather than using the legacy implementations.

100% agree!

I rearranged the Greenfield API section, but the "+ Create Token" button seemed unhappy about it, as you can see in this screenshot:
Screenshot 2024-01-02 150229

I adjusted its position a bit lower:

Screenshot 2024-01-02 151201

Let me know what you think. Thanks!

dennisreimann
dennisreimann approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@dennisreimann dennisreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Readjusted the button and improved the link to use the asp-action property.

grafik

@Kukks Kukks merged commit 78882dc into btcpayserver:master Jan 3, 2024
4 checks passed
@Kukks Kukks mentioned this pull request Jan 3, 2024
Closed
@hiluan hiluan deleted the 5571 branch January 3, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisreimann dennisreimann dennisreimann approved these changes

@Kukks Kukks Kukks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hiluan @dennisreimann @Kukks