-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store Branding: Apply brand color to backend as well #5992
base: master
Are you sure you want to change the base?
Store Branding: Apply brand color to backend as well #5992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good AFAICT.
tACK!
Another pair of eyes wouldn't hurt though
Few thoughts:
- if the user chooses a yellow, it might look bad on Light mode, etc... but i guess the user will figure this out pretty quickly, which leads me to...
- Also realizing i didn't test, but does just removing a custom HEX value default back to the BTCPAY green? we should probably have a way to opt back into the default
Yes it does.
Vice versa with dark brand color in dark mode. Not sure if we want to touch this — in 1b7718e I made an attempt at it and adjust the colors based on the brightness of the brand color. I think it covers it well enough to be safe, but I'm not sure if it's wanted. Yet it might be better than the status quo, in which there are brand color and theme combinations, which would not work. |
Ahh great - will take another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think your solution handles the variability pretty well, we can always patch if we think of something better
tACK
1b7718e
to
b759b6f
Compare
For now we only apply the store branding on public pages — this adds it to the store's backend as well. Closes #5990.