Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prestashop module review - Edge case improvements #121

Merged
merged 9 commits into from
Apr 8, 2024
Merged

Conversation

BitcoinMitchell
Copy link
Collaborator

Description

General fixes based on the feedback from the Prestashop Module team. There are still a lot of edge-cases that I hadn't found, didn't test, etc.

This resolves quite a few of them.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change which improves the codebase)

How Has This Been Tested?

Test Configuration:

  • BTCPay Server version: v1.13
  • PrestaShop version: 8.1.0
  • PHP version: 8.1.22

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings

@BitcoinMitchell BitcoinMitchell self-assigned this Apr 7, 2024
@BitcoinMitchell BitcoinMitchell changed the title Changes Prestashop module review - Edge case improvements Apr 7, 2024
Copy link
Contributor

@ndeet ndeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and LGTM!

@BitcoinMitchell BitcoinMitchell merged commit 0ea3887 into 6.x Apr 8, 2024
4 checks passed
@BitcoinMitchell BitcoinMitchell deleted the changes branch April 8, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants