Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getblock on tip returns an empty string for nextblockhash #416

Closed
arnuschky opened this issue May 4, 2015 · 3 comments · Fixed by #417
Closed

getblock on tip returns an empty string for nextblockhash #416

arnuschky opened this issue May 4, 2015 · 3 comments · Fixed by #417
Labels
compatibility

Comments

@arnuschky
Copy link

Not sure whether this is the intended behavior. On bitcoin core, nextblockhash is not in the dictionary.
davecgh added a commit to davecgh/btcd that referenced this issue May 4, 2015
@davecgh
rpcserver: Omit empty getblock->nextblockhash.
9f4eb24 
This commit omits the nextblockhash field from the getblock RPC result
when there isn't one (i.e for currnet the tip).

Closes btcsuite#416.
davecgh added a commit to davecgh/btcd that referenced this issue May 4, 2015
@davecgh
rpcserver: Omit empty getblock->nextblockhash.
9a658c2 
This commit omits the nextblockhash field from the getblock RPC result
when there isn't one (i.e for current the tip).

Closes btcsuite#416.
@davecgh davecgh mentioned this issue May 4, 2015
Merged
@davecgh
Copy link
Member

davecgh commented May 4, 2015

Thanks.

I just pushed a PR which changes it. Realistically empty versus not present isn't a big deal (it's trivial to check for == ""), but for the sake of compatibility, I pushed the PR.

@arnuschky
Copy link
Author

Great, thanks. I wasn't sure whether there's a convention wrt to empty keys.

@arnuschky
Copy link
Author

Confirmed working here, thanks.

@arnuschky arnuschky mentioned this issue May 5, 2015
Closed
cjepson pushed a commit to cjepson/btcd that referenced this issue Oct 11, 2016
@dajohi @jrick
dcrctl: fix output in --terminal mode (btcsuite#416)
d4860d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpcserver: Omit empty getblock->nextblockhash. davecgh/btcd
2 participants
@arnuschky @davecgh