Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btcctl tries to make btcd.conf when using wallet #875

Closed
carryforward opened this issue Dec 5, 2016 · 2 comments
Closed

btcctl tries to make btcd.conf when using wallet #875

carryforward opened this issue Dec 5, 2016 · 2 comments

Comments

@carryforward
Copy link
Contributor

ported from btcsuite/btcwallet#460

when I use btcctl to access a wallet, it tries to make a btcd.conf in the .btcd directory. I do not have btcd on the same computer as the wallet, and automatically making a config file is silly when I am not even trying to access the program that uses it.

btcctl --wallet --testnet -u username -P password listaccounts
Error creating a default config file: open /home/factom/.btcd/btcd.conf: no such file or directory

perhaps if I were trying to control btcd, this would make sense, but not with the wallet.
@carryforward carryforward mentioned this issue Dec 5, 2016
Closed
@davecgh
Copy link
Member

davecgh commented Dec 6, 2016

Nice catch. It shouldn't try to create btcctl.conf when the --wallet flag is set

jimpo pushed a commit to jimpo/btcd that referenced this issue Aug 1, 2017
Read RPC username/pass from correct config file for btcctl defaults.
28c5bce 
If no existing btcctl.conf file exists, btcctl creates a default one
using the RPC username and password from the btcd.conf. If the
--wallet flag is passed, however, it should read from btcwallet.conf
instead.

btcsuite#875.
@jimpo jimpo mentioned this issue Aug 1, 2017
Merged
davecgh pushed a commit that referenced this issue Aug 14, 2017
@davecgh
Read RPC username/pass from correct config file for btcctl defaults.
e736ae1 
If no existing btcctl.conf file exists, btcctl creates a default one
using the RPC username and password from the btcd.conf. If the
--wallet flag is passed, however, it should read from btcwallet.conf
instead.

#875.
@davecgh
Copy link
Member

davecgh commented Aug 14, 2017

Fixed by #972

@davecgh davecgh closed this as completed Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davecgh @carryforward and others