release: create release branch for v0.22.2 to backport block parsing issue #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we fix a bug that would cause nodes to be unable to parse a given block from the wire. The block would be properly accepted if fed in via other mechanisms. The issue here is that the old checks for the maximum witness size, circa segwit v0 where placed in the wire package _as well_ as the tx engine. This check should only be in the engine, since it's properly gated by other related scrip validation flags. The fix itself is simple: limit witnesses only based on the maximum block size in bytes, or ~4MB.
This changes isDust to IsDust so other golang projects (btcwallet or lnd) can use the precise dust calculation used by btcd.
Roasbeef
force-pushed
the
v-0-22-branch
branch
2 times, most recently
from
ae4a951
to
f9ca8c0
Compare
This commit modifies no behavior and would allow other projects to retrieve the dust limit for a particular output type before the amount of the output is known. This is particularly useful in the Lightning Network for channel negotiation.
Roasbeef
force-pushed
the
v-0-22-branch
branch
from
f9ca8c0
to
d8612c5
Compare
|
CI seems to be failing since a file that's assumed in the CI checks is no longer in the repo? edit: aaaand CI is gone all together? |
|
Tacked that commit on above in the end. |
Roasbeef
force-pushed
the
v-0-22-branch
branch
from
d8612c5
to
badf3fd
Compare
Roasbeef
force-pushed
the
v-0-22-branch
branch
from
badf3fd
to
ba2fba5
Compare
|
Tests all pass for me locally, but it's using an ancient version of Go in the CI since that's what we had checked in at the time. |
CHAINZ32
reviewed
Oct 14, 2022
| @@ -204,7 +204,7 @@ func TestCheckPkScriptStandard(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // TestDust tests the isDust API. | |||
| // TestDust tests the IsDust API. | |||
| func TestDust(t *testing.T) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.