Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main: Update README.md's minimum go version #1977

Merged
merged 2 commits into from May 24, 2023
Merged

main: Update README.md's minimum go version #1977

merged 2 commits into from May 24, 2023

Conversation

kcalvinalvin
Copy link
Collaborator

The readme suggests a minimum version of 1.16 but the go.mod requires go 1.17.

@kcalvinalvin
main: Update README.md's minimum go version
218c475 
The readme suggests a minimum version of 1.16 but the go.mod requires go
1.17.
@coveralls
Copy link

coveralls commented May 5, 2023 •
edited

Pull Request Test Coverage Report for Build 5042735441

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 180 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 55.255%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 4 73.2%
blockchain/utxoviewpoint.go 12 70.59%
btcd.go 64 2.49%
config.go 100 5.24%
Totals Coverage Status
Change from base Build 4755006470: -0.02%
Covered Lines: 26649
Relevant Lines: 48229
💛 - Coveralls

guggero
guggero reviewed May 8, 2023
View reviewed changes
README.md Show resolved Hide resolved
Roasbeef
Roasbeef approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐅

@Roasbeef Roasbeef merged commit 4749f7a into btcsuite:master May 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kcalvinalvin @coveralls @Roasbeef @guggero