Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcclient: catch shutdown signal when sending RPC requests #2028

Merged
merged 4 commits into from Sep 5, 2023
Merged

rpcclient: catch shutdown signal when sending RPC requests #2028

merged 4 commits into from Sep 5, 2023

Conversation

yyforyongyu
Copy link
Contributor

This PR updates gitignore, go mod, and catches shutdown signal when sending RPC requests.

guggero
guggero approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, LGTM 🎉

Roasbeef
Roasbeef approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦖

@Roasbeef Roasbeef merged commit 80f5a0f into btcsuite:master Sep 5, 2023
3 checks passed
@yyforyongyu yyforyongyu deleted the catch-shutdown branch September 5, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yyforyongyu @Roasbeef @guggero