wire, netsync: change isSyncCandidate behavior #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeNetworkLimitedBlockThreshold is a constant representing how many blocks from tip a node signaling NODE_NETWORK_LIMITED must serve.
|
cc @ellemouton |
ellemouton
approved these changes
Oct 17, 2023
halseth
approved these changes
Oct 27, 2023
wire/protocol.go
Outdated
| @@ -151,6 +151,12 @@ func (f ServiceFlag) String() string { | |||
| return s | |||
| } | |||
|
|
|||
| const ( | |||
There was a problem hiding this comment.
nit: declare up with the service flags? This location seems a bit arbitrary
isSyncCandidate is now changed to return true even if the peer is a pruned node if and only if our chaintip is within 288 blocks of the peer. Rationale: Pruned nodes that signal NODE_NETWORK_LIMITED MUST serve 288 blocks from their chaintip. If our chaintip is within that range, this peer can be a sync candidate even if they aren't an archival node.
kcalvinalvin
force-pushed
the
2023-09-25-change-is-sync-candidate-behavior
branch
from
8cecc41
to
b4992fe
Compare
Pull Request Test Coverage Report for Build 6779126378
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isSyncCandidate is now changed to return true even if the peer is a
pruned node if and only if our chaintip is within 288 blocks of the
peer.
Rationale being that pruned nodes that signal NODE_NETWORK_LIMITED
MUST serve 288 blocks from their chaintip. If our chaintip is within that
range, this peer can be a sync candidate even if they aren't an archival node.