refactor: set strconv.ParseFloat bitsize to 64 #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9348538620Details
💛 - Coveralls |
guggero
approved these changes
Nov 27, 2023
|
@guggero Hi sir, can we get this merged then~ |
|
Can you please remove the merge commit by rebasing? |
lilasxie
force-pushed
the
refactor/parsefloat
branch
from
b2a28e8
to
cccaa5f
Compare
@guggero Hi sir, suggestion addressed |
guggero
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strconv.ParseFloatwill always treatbizSizeparameter as 64 if we don't set it to 32, it's odd to set it to 0, although this won't affect the result