Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the btcctl uptime command #2203

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix the btcctl uptime command #2203

merged 1 commit into from
Jun 27, 2024

Conversation

cec489
Copy link
Contributor

@cec489 cec489 commented Jun 24, 2024 •
edited
Loading

fixing #2202

@cec489 cec489 changed the title Fix the btcctl uptime command by moving the setting of startupTime Fix the btcctl uptime command Jun 24, 2024
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9651666268

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.007%) to 57.24%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
mempool/mempool.go 1 66.67%
connmgr/connmanager.go 2 86.62%
Totals Coverage Status
Change from base Build 9610935276: -0.007%
Covered Lines: 29799
Relevant Lines: 52060
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9651375858

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 149 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.007%) to 57.24%
Files with Coverage Reduction New Missed Lines %
mempool/mempool.go 1 66.67%
connmgr/connmanager.go 3 86.27%
server.go 145 0.0%
Totals Coverage Status
Change from base Build 9610935276: -0.007%
Covered Lines: 29798
Relevant Lines: 52058
💛 - Coveralls

jcvernaleo
jcvernaleo requested changes Jun 26, 2024
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cec489 Could you squash this to 1 commit? After that I can approve and merge.

@cec489
Squashed commit of the following:
2f66d20 
commit 0b2998b
Author: cec489 <173723251+cec489@users.noreply.github.com>
Date:   Mon Jun 24 20:01:13 2024 +0000

    A cleaner fix is to set the startTime in the server Start() function
    which is where the server is actually started.

commit ae6c125
Author: cec489 <173723251+cec489@users.noreply.github.com>
Date:   Mon Jun 24 19:15:23 2024 +0000

    Fix the btcctl uptime command by moving the setting of startupTime
@cec489
Copy link
Contributor Author

cec489 commented Jun 27, 2024

@jcvernaleo Thanks... just squashed the commits

@cec489 cec489 requested a review from jcvernaleo June 27, 2024 15:20
@coveralls
Copy link

coveralls commented Jun 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9698818152

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 57.216%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
btcec/schnorr/musig2/sign.go 2 90.44%
Totals Coverage Status
Change from base Build 9686491477: 0.01%
Covered Lines: 29826
Relevant Lines: 52129
💛 - Coveralls

jcvernaleo
jcvernaleo approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo jcvernaleo merged commit d881c68 into btcsuite:master Jun 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cec489 @coveralls @jcvernaleo