Fix --onion. #446
Merged
Fix --onion. #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configured onion proxy was not being used due to checking if the passed string had suffix '.onion', which never matched because the port number is part of the string.
|
Looks ok but I would add a precondition in the function comment that the address needs the ":port" at the end. |
|
OK |
ishbir
added a commit
to ishbir/bmd
that referenced
this pull request
Jun 23, 2015
--onion option was broken earlier. Mirrored upstream change btcsuite/btcd#446. RPC server has now been updated to send objects to clients in strictly sequential order of counters. This was accomplished using heaps. RPC documentation has also been updated to reflect the same. Method signatures of a few database functions have been changed. RemoveExpiredObjects now returns the list of objects that it pruned from the database. This is going to be useful for the object manager, to remove those objects from the list of advertised objects. PubKey operations have been improved and ciphering support (now a part of bmutil) has been integrated. Tests for the same have also been added. Storage of public keys has been optimized. Unencrypted and encrypted messages are now stored separately. This is more efficient than storing everything together.
ishbir
added a commit
to ishbir/bmd
that referenced
this pull request
Jun 23, 2015
--onion option was broken earlier. Mirrored upstream change btcsuite/btcd#446. RPC server has now been updated to send objects to clients in strictly sequential order of counters. This was accomplished using heaps. RPC documentation has also been updated to reflect the same. Method signatures of a few database functions have been changed. RemoveExpiredObjects now returns the list of objects that it pruned from the database. This is going to be useful for the object manager, to remove those objects from the list of advertised objects. PubKey operations have been improved and ciphering support (now a part of bmutil) has been integrated. Tests for the same have also been added. Storage of public keys has been optimized. Unencrypted and encrypted messages are now stored separately. This is more efficient than storing everything together.
ishbir
added a commit
to ishbir/bmd
that referenced
this pull request
Jun 23, 2015
--onion option was broken earlier. Mirrored upstream change btcsuite/btcd#446. RPC server has now been updated to send objects to clients in strictly sequential order of counters. This was accomplished using heaps. RPC documentation has also been updated to reflect the same. Method signatures of a few database functions have been changed. RemoveExpiredObjects now returns the list of objects that it pruned from the database. This is going to be useful for the object manager, to remove those objects from the list of advertised objects. PubKey operations have been improved and ciphering support (now a part of bmutil) has been integrated. Tests for the same have also been added. Storage of public keys has been optimized. Unencrypted and encrypted messages are now stored separately. This is more efficient than storing everything together.
jrick
pushed a commit
to jrick/btcd
that referenced
this pull request
Nov 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configured onion proxy was not being used due to checking if the
passed string had suffix '.onion', which never matched because the
port number is part of the string.