mining: Improve tests for prio queue. #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks ok. My only suggestion is to use a random seed and if any of the tests fail, then the seed can be printed so the test can be reproduced, but this is still an improvement by itself so that's no reason to hold up the PR. |
davecgh
force-pushed
the
mining_prioqueue_improve_test
branch
from
675ff43
to
ec82b90
Compare
|
Good suggestion. I've updated the PR to create a new random source from a random seed and log the seed. |
davecgh
force-pushed
the
mining_prioqueue_improve_test
branch
from
ec82b90
to
1527807
Compare
|
I would only print it if the test failed: defer func() {
if t.Failed() {
t.Logf("Random numbers generated using seed %v", randSeed)
}
}() |
This improves the tests of the priority queue to include the secondary sort ordering as well as adds some manual entries to ensure the edge conditions are properly tested. This also brings the priority queue test coverage up to 100%.
davecgh
force-pushed
the
mining_prioqueue_improve_test
branch
from
1527807
to
cbf994e
Compare
|
Updated to only print seed on failure with defer. |
|
ok |
cjepson
pushed a commit
to cjepson/btcd
that referenced
this pull request
Sep 21, 2016
This improves the tests of the priority queue to include the secondary sort ordering as well as adds some manual entries to ensure the edge conditions are properly tested. This also brings the priority queue test coverage up to 100%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the tests of the priority queue to include the secondary sort ordering as well as adds some manual entries to ensure the edge conditions are properly tested.
This also brings the priority queue test coverage up to 100%.
This change is