Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/slice docummentation #40

Merged
merged 6 commits into from
Mar 30, 2020
Merged

Feature/slice docummentation #40

merged 6 commits into from
Mar 30, 2020

Conversation

gustavosinbandera1
Copy link
Contributor

No description provided.

luisan00
luisan00 approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@luisan00 luisan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@luisan00
Copy link
Member

This fixes #39

@luisan00 luisan00 mentioned this pull request Mar 30, 2020
Closed
jeandudey
jeandudey suggested changes Mar 30, 2020
View reviewed changes
Copy link
Member

@jeandudey jeandudey left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only fix the README.MD (Maybe rename it to README.md with lowercase extension so other editors can recognize it). Overall seems good to be merged, only that.

documentation/ES/README.MD Outdated Show resolved Hide resolved
@gustavosinbandera1 gustavosinbandera1 removed the request for review from rdymac March 30, 2020 18:47
luisan00
luisan00 approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@luisan00 luisan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gustavosinbandera1 gustavosinbandera1 merged commit 986dac1 into dev Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeandudey jeandudey jeandudey approved these changes

@luisan00 luisan00 luisan00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gustavosinbandera1 @luisan00 @jeandudey