User button multi Function #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisan00
added
Type: enhancement
jeandudey
suggested changes
Jan 7, 2020
Comment on lines
+20
to
+22
| /** | ||
| * @brief Construct a new OneButton object but not (yet) initialize the IO pin. | ||
| */ |
Comment on lines
+28
to
+34
| /** | ||
| * @brief Construct a new Button:: Button object | ||
| * | ||
| * @param gpio | ||
| * @param activeLow | ||
| * @param pullupActive | ||
| */ |
| { | ||
| } //Button | ||
|
|
||
| // save function for click event |
There was a problem hiding this comment.
This comment repeats what is on the doc comment.
Comment on lines
+40
to
+44
| /** | ||
| * @brief save function for click event | ||
| * | ||
| * @param newFunction callback function | ||
| */ |
Comment on lines
+23
to
+26
| Button::Button() | ||
| { | ||
| _gpio_btn = static_cast<gpio_num_t>(-1); | ||
| } |
There was a problem hiding this comment.
Why this constructor exists? It creates an invalid _gpio_btn. Does it has an use?
There was a problem hiding this comment.
you right , I need to remove it
| { | ||
| public: | ||
| Button(); | ||
| Button(gpio_num_t gpio, int active, bool pullupActive = true); |
| BTN_END_PROCESS, | ||
| } state; | ||
|
|
||
| class Button //: Task |
There was a problem hiding this comment.
- Class documentation
- Unused code? I mean
: Task
| void tick(bool level, unsigned long time_now); | ||
|
|
||
| bool isLongPressed(); | ||
| int getPressedTicks(); |
There was a problem hiding this comment.
Shouldn't it return TickType_t (type safety)?
Comment on lines
+79
to
+110
| bool _updated_level; // hardware gpio number. | ||
| unsigned int _debounceTicks = 200; // number of ticks for debounce times. | ||
| unsigned long _clickTicks = 250; // number of ticks that have to pass by | ||
| // before a click is detected. | ||
| unsigned long _long_press_ticks = 1500; // number of ticks that have to pass by | ||
| // before a long button press is detected | ||
|
|
||
| int _buttonPressed; | ||
| bool _isLongPressed = false; | ||
| long int _timeout = 500; | ||
|
|
||
| // These variables that hold information across the upcoming tick calls. | ||
| // They are initialized once on program start and are updated every time the | ||
| // tick function is called. | ||
| int _state = 0; | ||
| unsigned long _startTime; // will be set in state 1 | ||
| unsigned long _stopTime; // will be set in state 2 | ||
|
|
||
| // These variables will hold functions acting as event source. | ||
| callbackFunction _clickFunc = NULL; | ||
| parameterizedCallbackFunction _paramClickFunc = NULL; | ||
| void* _clickFuncParam = NULL; | ||
|
|
||
| callbackFunction _doubleClickFunc = NULL; | ||
| parameterizedCallbackFunction _paramDoubleClickFunc = NULL; | ||
| void* _doubleClickFuncParam = NULL; | ||
|
|
||
|
|
||
| callbackFunction _longClickFunc = NULL; | ||
| parameterizedCallbackFunction _paramLongClickFunc = NULL; | ||
| void* _longClickFuncParam = NULL; | ||
|
|
There was a problem hiding this comment.
- Use the m_ prefix for member variables (private).
snakeCasetosnake_case.- Use doxygen comments.
Comment on lines
+9
to
+10
| typedef void (*callbackFunction)(void); | ||
| typedef void (*parameterizedCallbackFunction)(void*); |
There was a problem hiding this comment.
New types should be SnakeCase to not confuse them with a function or variable.
|
This needs to be resolved guys 🇳🇮 🇻🇪 🇨🇴 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plz dont accept this PR now, I need to implement the needed functions to turn on/off device