Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sapling viewing keys | 2.0.8 #69

Closed
wants to merge 19 commits into from

Conversation

MarcelusCH
Copy link
Member

As our discussion on Discord, we go now forward with sapling viewing keys .

References:

I think that this are the needed dependencies for doing it (by this initial PR).
The different updates have been committed with same PR name as zcash core node.

I will commit the bellow updates as well into the BtcZ node v2.0.8-rc1 (or should this may be a beta?):

Change log up to this PR open

add z_gettreestate RPC
Fix the use of 0 as expiryheight in createrawtransaction, to disable expiry
Bitcoin 0.12 wallet PRs 1
Fix CVE-2017-18350
Wallet interface refactor
Update z_viewtransaction
insightexplorer: LOCK(cs_main) during rpcs
Return address and type of imported key in z_importkey

@MarcelusCH MarcelusCH linked an issue Jul 3, 2022 that may be closed by this pull request
@MarcelusCH
Copy link
Member Author

Ok, there are some more update to pull in before to be able to merge successfully the import/export/init usage of full viewing key.
Here is the backward compatibility list of what we need some of (not all).
https://github.com/zcash/zcash/pulls?page=38&q=is%3Apr+is%3Aclosed
But I stuck one witch one is depending each other.
(We not schould add every update)

 (+ upstream PRs relating to)
@MarcelusCH
Copy link
Member Author

MarcelusCH commented Jul 24, 2022

Added also the followings update in the last commit :

This commit allows now the binaries to be compiled (on ubuntu 20.04) and to use the z_importviewingkey, z_exportviewingkey, and also to able to see the shilded tx with only the viewing key (instead the std spending key) with the z_viewtransaction function.

@MarcelusCH MarcelusCH changed the title Implement sapling viewing keys | 2.0.8-rc1 (beta ?) Implement sapling viewing keys | 2.0.8-rc1 Jul 24, 2022
@MarcelusCH MarcelusCH changed the base branch from master to 2.0.8-rc1 July 29, 2022 08:32
@MarcelusCH MarcelusCH changed the title Implement sapling viewing keys | 2.0.8-rc1 Implement sapling viewing keys | 2.0.8 Sep 3, 2022
@MarcelusCH
Copy link
Member Author

Updated deprecation to blk 1208650 (AUG 2023) and renamed as stable version.

@MarcelusCH MarcelusCH changed the base branch from 2.0.8-rc1 to master September 3, 2022 11:45
@cryptorex cryptorex mentioned this pull request Sep 9, 2022
@cryptorex
Copy link
Member

this was merged in #70

@cryptorex cryptorex closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add founderaddress to gbt
2 participants