This repository has been archived by the owner on Jan 2, 2018. It is now read-only.
Submodules fix #82
Merged
Submodules fix #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Большое спасибо, Михаил. Я сабмодули не использовал, вот и не замечал проблемы. ЗЫ Я если честно думал что вы перехали на gitlab. |
|
Да мы ленивые, типа работает -- не трогай :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Денис, добрый день.
Я тут нашел такой неприятный баг: если в репозиторий добавить сабмодуль то дерево перестает показываться. Это происходит потому что в ls_tree filemode проверяется только на TREE или не TREE, соотвественно FileMode.GITLINK попадало в ветку для Blob. И потом вызывался getObjectSize который завершался исключением.
Ну и я еще немного зависимости освежил. Вроде бы все работает :)