-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new Include and Exclude is hard to understand and use #149
Comments
same as |
I am closing this. As i am not going to work on this. If anyone want to provide feedback on how it should be done, instead of rant - very welcome to issues and PR. |
My expect behavior is just the version before 5.9.0. Seems 5.9.0 change the filter behavior a lot |
@btd is there any documentation anywhere that explains how to use the filters? Thanks :) |
I cannot get the exclude/include filters to work. I don't want to repeat the previous comment but I really have no clue how it works. |
There is unit test for this https://github.com/btd/rollup-plugin-visualizer/blob/master/shared/create-filter.test.ts I perfectly understand that this change was very controversial. But i think it provides more flexibility in general way. You can search there was tickets about previous input/output filters also. To me it looks like what ever i do people will complain. So until i see any reasonable proposal i am not going to change anything in this. I spend on this plugin my free time (you can see when first commit was done and how many years i am doing this for free), i do not receive any PRs or donations. I even do not use to for my daily work as it was in past. And still trying to provide support and maintenance. It is opensource at the end and there is a button on top right to fork it. I will continue provide maintenance and support of my version. |
@danielpza @stereokai i added small README section https://github.com/btd/rollup-plugin-visualizer/blob/master/README.md#include-and-exclude It is just glob patterns. To be honest i first time in my career see that somebody prefer raw regexp to glob pattern. |
Thank you @btd. This makes it a lot clearer. |
I just want to filter lodash chunks, with the latest version, I don't know how to do it.
I try following input, but result doesn't expected.
In old version 5.8.3, I just need input exlcude:
.
, include:lodash
:Maybe another issue, After I empty the inputs, there is no result:
The description is also very confused:
It means it support input
bundle-*:*
?Versions:
The text was updated successfully, but these errors were encountered: