Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new Include and Exclude is hard to understand and use #149

Closed
tjx666 opened this issue Jan 11, 2023 · 9 comments
Closed

new Include and Exclude is hard to understand and use #149

tjx666 opened this issue Jan 11, 2023 · 9 comments

Comments

@tjx666
Copy link

tjx666 commented Jan 11, 2023

I just want to filter lodash chunks, with the latest version, I don't know how to do it.

image

I try following input, but result doesn't expected.

image

In old version 5.8.3, I just need input exlcude: ., include: lodash:

image

Maybe another issue, After I empty the inputs, there is no result:

image

The description is also very confused:

image

It means it support input bundle-*:* ?

Versions:

Packages:
    "rollup": "^3.9.1",
    "rollup-plugin-visualizer": "^5.9.0"
System:
    OS: macOS 13.1
    CPU: (8) x64 Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz
    Memory: 158.41 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
@vaynevayne
Copy link

same as

@btd
Copy link
Owner

btd commented Jun 10, 2023

I am closing this. As i am not going to work on this. If anyone want to provide feedback on how it should be done, instead of rant - very welcome to issues and PR.

@btd btd closed this as completed Jun 10, 2023
@tjx666
Copy link
Author

tjx666 commented Jun 11, 2023

My expect behavior is just the version before 5.9.0. Seems 5.9.0 change the filter behavior a lot

@stereokai
Copy link

@btd is there any documentation anywhere that explains how to use the filters? Thanks :)

@danielpza
Copy link

I cannot get the exclude/include filters to work. I don't want to repeat the previous comment but I really have no clue how it works.

@btd
Copy link
Owner

btd commented Nov 30, 2023

There is unit test for this https://github.com/btd/rollup-plugin-visualizer/blob/master/shared/create-filter.test.ts
If you want create PR to update readme.

I perfectly understand that this change was very controversial. But i think it provides more flexibility in general way. You can search there was tickets about previous input/output filters also.

To me it looks like what ever i do people will complain. So until i see any reasonable proposal i am not going to change anything in this. I spend on this plugin my free time (you can see when first commit was done and how many years i am doing this for free), i do not receive any PRs or donations. I even do not use to for my daily work as it was in past. And still trying to provide support and maintenance.

It is opensource at the end and there is a button on top right to fork it. I will continue provide maintenance and support of my version.

@btd
Copy link
Owner

btd commented Dec 3, 2023

@danielpza @stereokai i added small README section https://github.com/btd/rollup-plugin-visualizer/blob/master/README.md#include-and-exclude

It is just glob patterns. To be honest i first time in my career see that somebody prefer raw regexp to glob pattern.

@danielpza
Copy link

Thank you @btd. This makes it a lot clearer.

@stereokai
Copy link

stereokai commented Dec 6, 2023

@btd Wow, thank you very @btd, that's very thoughtful of you. I had figured it out by then but the addition to the readme will definitely come in handy later since I had also already forgot 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants