feat: added remote resources, i.e. pools, nodes #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohager
commented
Sep 20, 2023
| @@ -29,18 +29,18 @@ dependencies { | |||
| implementation 'com.github.signum-network:signumj:abd8563d73' | |||
| implementation 'com.github.signum-network:signum-smartj:89e2f28bb3' | |||
|
|
|||
| implementation 'com.google.code.gson:gson:2.8.6' | |||
| implementation 'com.google.code.gson:gson:2.8.9' | |||
There was a problem hiding this comment.
previous version was marked as vulnerable
ohager
commented
Sep 20, 2023
| }; | ||
| public static final String REMOTE_NODE_RESOURCES_URL = "https://signum-network.github.io/public-resources"; | ||
|
|
||
| public static final String[] NODE_LIST_TESTNET = { |
There was a problem hiding this comment.
Constants serve as fallback
This was referenced Sep 20, 2023
|
i'm excited about this one! will allow pools to be dynamically updated in btdex without everyone having to wait for a new version release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added remotely configurable Pool and Node List from https://github.com/signum-network/public-resources
this also solve #247