Skip to content

Commit

Permalink
Added rule about client-generated request ids
Browse files Browse the repository at this point in the history
  • Loading branch information
JeffreyRichter committed Mar 1, 2019
1 parent 3a0479b commit 44ecaf8
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions docs/design/Retry.mdk
Expand Up @@ -23,7 +23,7 @@ reset (or seek back to position 0) any request data stream before retrying a req
~

~ Must {#general-retry-honor-caller-cancellation}
honor any cancellation mechanism passed-in be the caller which can terminate the request before retries have been attempted.
honor any cancellation mechanism passed-in to the caller which can terminate the request before retries have been attempted.
~

~ Must {#general-retry-update-time-to-live}
Expand All @@ -35,7 +35,7 @@ retry in the case of a hardware network failure as it may self-correct
~

~ Must {#general-retry-on-service-not-found}
retry in the case of a service not found error as the service may be coming back online or a load balancer may be reconfiguring itself.
retry in the case of a "service not found" error as the service may be coming back online or a load balancer may be reconfiguring itself.
~

~ Must {#general-retry-on-per-try-timeout}
Expand All @@ -48,4 +48,9 @@ retry if the service successfully responds indicating that it is throttling requ

~ MustNot {#general-retry-no-retry-if-successfully-failed}
retry if the service successfully responds indicating that the requested operation failed.
~

~ MustNot {#general-retry-no-change-request-id}
change any client-side generated request-id as this represents the logical operation and should be the same across all physical retries of this operation.
When looking at server logs, multiple entries with the same client request-id show each retry and this is useful information to help diagnose issues.
~

0 comments on commit 44ecaf8

Please sign in to comment.