-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -u|--unanimous flag: easily identify whether all engines agree on output #22
Comments
I think communicating the hosts with different results via exit code isn't a great design. Probably the stdout should contain this info in an easily parseable format? |
@bterlson Yeah, communication via the exit code was a bit of a stretch. I'd say the output format is not necessarily super important for a first pass at this feature, but an easily-parseable format would definitely be good. I'm trying to decide whether the current default collated output is not, in fact, easily parseable. I suppose the only problematic things are the colors and if your test output has a line that starts with |
Started work on this here: https://github.com/dilijev/eshost-cli/tree/quorum |
Renaming option to --unanimous as per feedback in #35 |
…ilijev-quorum * 'quorum' of https://github.com/dilijev/eshost-cli: Rename `--quorum, -q` to `--unanimous, -u` Resolve bterlson#22: `--quorum` will exit(0) and output nothing if all hosts agree.
To help with automatic comparative testing between engines, add a
-q|--quorum
flag. Behavior will be as follows:0
.1
(1 + the index of the engine in the config file)
to more easily identify which engine disagreed. Perhaps-1
if more than one engine disagrees or there is a greater than 2-way split on the outputs./cc @bterlson
The text was updated successfully, but these errors were encountered: