-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort host list by name #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's wrong with always sorting? First-to-complete gets you results earlier potentially, but it feels like overkill to require an option for it...
@bterlson Always sorting makes some kind of sense, but the default listing is in config-order which might be significant to the user. Didn't want to make that call necessarily. By the way this isn't for running scripts. Those are now in alpha-sorted order by default when using |
I think sorting always is fine, personally. I see it as the moral equivalence of |
When I reviewed this last week I thought a bit about the sorting and wondered whether a user might also want to sort by other columns (by providing the column name) and I spent sometime sketching that out; but ultimately I decided against pursuing it and reasoned that if eshost-cli wanted to grow that capability, then it could without an issue and that this was a reasonable place to start, while also not that could be extended later. But then...
...is definitely compelling. So +1 to always sorting. |
Okay, always sorting is vastly simpler. I doubt the small audience of this tool is going to have someone whose workflow is broken by things being in a different order. I'll make the update soon. |
@bterlson lol one line change when it's not optional |
--list
the --sort
option: sort host list by name
No description provided.