Update assert.throws from code review comments

See tc39/test262#131.
bterlson · Dec 5, 2014 · 523802a · 523802a
1 parent 28f5c02
commit 523802a
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/lib/helpers/assert.js b/lib/helpers/assert.js
@@ -41,12 +41,18 @@ assert.notSameValue = function (actual, unexpected, message) {
     $ERROR(message);
 };
 
-assert.throws = function (expectedErrorConstructor, func, message) {
+assert.throws = function (expectedErrorConstructor, func) {
+    if (func === undefined) {
+        $ERROR('assert.throws requires two arguments: the error constructor and a function to run');
+        return;
+    }
+
     try {
         func();
     } catch (thrown) {
         if (typeof thrown !== 'object' || thrown === null) {
             $ERROR('Thrown value was not an object!');
+            return;
         }
         if (thrown.constructor !== expectedErrorConstructor) {
             $ERROR('Expected a ' + expectedErrorConstructor.name + ' but got a ' + thrown.constructor.name);