Run tests over subfolders #53
Conversation
|
Plus, for clarification: setting a folder will run the tests through each subfolder, similarly the behavior of the deprecated test262 python runner. Edit: a |
| if (fs.statSync(path).isDirectory()) { | ||
| path += '/**/*.js'; | ||
| } | ||
| } catch(e) {} |
There was a problem hiding this comment.
this try catch was necessary to avoid abruptions where the path is not expanded by default. This is perceived within the collateral tests. I'm not exactly sure how to make it safe before fs.statSync(path). Any known best practice?
|
ok, I've fixed the PR removing the files duplication. This change limited the possible valid paths, but the valid options are still an extension from the possibilities before this patch. This change limits the tool from diving recursively on subfolders, unless it's explicitly flagged as a glob pattern:
These are now only considering npm-glob patterns, assuming the path arg needs to be wrapped under quotes on *nix systems cli usage to avoid path extension. |
|
|
||
| fileEvents.on('match', function (file) { | ||
| files.onNext(file); | ||
| if (fs.statSync(file).isFile()) { |
There was a problem hiding this comment.
Glob has an option, "nodir", which will prevent it from matching directories. I think adding that option would do the same thing as this PR?
leobalter
force-pushed
the
glob
branch
4 times, most recently
from
d9dde2a
to
fec20dd
Compare
|
at the end, this became just a small change. The nodir is working just fine. |
With this patch, test262-harness does not break passing folders or finding subfolders.
passing different paths will now work, where before only these forms were valid:
test/built-ins/Reflect/*.jstest/built-ins/Reflect/**/*.jsNow these other forms will be valid as well:
test/built-ins/Reflect/*test/built-ins/Reflect/test/built-ins/ReflectThere's a last commit part where I still want to improve, rather than just setting a try catch. While I don't know how to solve it yet, I'll leave this open to request for some feedback.