Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support transpilation with Babel #74

Closed
wants to merge 3 commits into from
Closed

Conversation

littledan
Copy link
Contributor

Allows Babel to be used as a transpiler, before passing to the underlying host, with the command-line flag --babelPreset stage-2, for example.

Depends on this patch bterlson/eshost#19 , so eshost would have to rev a semver-minor and this patch would have to depend on that, before landing.

@rwaldron
Copy link
Collaborator

@littledan can you rebase this? thanks!

@littledan
Copy link
Contributor Author

Rebased, sorry for the delay here. @bterlson Could you take a look?

@bterlson
Copy link
Owner

LGTM!

@rwaldron
Copy link
Collaborator

rwaldron commented Jul 20, 2017

@littledan This depends on bterlson/eshost#19, right?

I will land this once travis goes green.

@bterlson
Copy link
Owner

Yes it does.

@leobalter
Copy link
Contributor

@littledan status? I would love to use this feature.

@leobalter
Copy link
Contributor

I guess the only missing part is bumping eshost to ^3.5.0? Let me check this

@leobalter
Copy link
Contributor

Running the tests locally, before and after rebasing (with clean npm installs) with the master branch. Makes the CI failures pass:

# Test requiring transpilation
ok 93 Test has an "expected" frontmatter
ok 94 Test passes or fails as expected
ok 95 should be equal
# Test requiring transpilation (Strict Mode)
ok 96 Test has an "expected" frontmatter
ok 97 Test passes or fails as expected
ok 98 should be equal

@littledan
Copy link
Contributor Author

Bumped the dependency; we'll see what CI says

@bterlson
Copy link
Owner

I think the only issue here is that those tests need to be async (see #85). Let's fix #85 and confirm.

@rwaldron
Copy link
Collaborator

Merged!

@rwaldron rwaldron closed this Aug 24, 2017
@littledan
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants