Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17] As a user, I can click a button to toggle display on the create report form #45

Merged
merged 12 commits into from
May 19, 2021

Conversation

bterone
Copy link
Owner

@bterone bterone commented Apr 28, 2021

Closes #17

What happened

✅: Hide the upload report form until the user clicks on the button.
✅: Minor touchup on buttons
✅: Put eslint in the project and in codebase check.

Insight

  • Used the dropdown library from bootstrap.

  • I ran into issues running feature tests on local. Updated my local chromedriver by updating the npm package chromedriver in my global packages to the latest version 90.0.44

Proof Of Work

upload-button

Swapped the colors of the buttons in report.show

Screen Shot 2021-04-29 at 4 22 56 PM

@bterone bterone added chore Something that doesn't bring direct value but is necessary frontend Anything that affects the UI/UX labels Apr 28, 2021
@bterone bterone self-assigned this Apr 28, 2021
@bterone bterone force-pushed the chore/redesign-website branch 9 times, most recently from a3af6d6 to e12d375 Compare April 29, 2021 09:23
@bterone bterone marked this pull request as ready for review April 29, 2021 09:25
@bterone bterone changed the title [44] Redesign Dashboard [17] As a user, I can click a button to toggle display on the create report form Apr 29, 2021
@bterone bterone mentioned this pull request Apr 29, 2021
* Component bootstrapping actions.
*/
_setup() {
this.uploadDropdown = new Dropdown(this.uploadReportButton);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we move "Dropdown" setup to the initializer then use data-toggle="dropdown" as a selector? So we don't need to initialize this in every screen.

Copy link
Owner Author

@bterone bterone May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really follow, don't we still need to initialize on each screen there's a drop-down anyways? Since this JS file is related to the dashboard screen only. 🤔

I've removed the dashboard component and move the setup here in 81b96cb,
but I'm also thinking we could also do something like we could export some default class selector from the Dropdown component as well.

I'm fine with either, what do you think? @hanam1ni

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check Initializers in this convention so we only need a single file to initialize the application-wide component.

Copy link
Owner Author

@bterone bterone May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I gotcha. I've done that in 019de1b 👍

@bterone bterone force-pushed the chore/redesign-website branch 2 times, most recently from 4914326 to 1fb6d17 Compare May 10, 2021 05:02
@bterone bterone added this to the 0.2.0 milestone May 16, 2021
@bterone bterone moved this from To do to Reviewer approved in G Searcher - Nice to haves May 16, 2021
@bterone bterone added the 0.2.0 label May 17, 2021
@bterone bterone merged commit 1e1a65d into develop May 19, 2021
G Searcher - Nice to haves automation moved this from Reviewer approved to Done May 19, 2021
@bterone bterone deleted the chore/redesign-website branch May 19, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2.0 chore Something that doesn't bring direct value but is necessary frontend Anything that affects the UI/UX
Development

Successfully merging this pull request may close these issues.

As a user, I can click a button to toggle display on the create report form
3 participants