-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17] As a user, I can click a button to toggle display on the create report form #45
Conversation
a3af6d6
to
e12d375
Compare
e12d375
to
ad7f971
Compare
assets/js/screens/Dashboard/index.js
Outdated
* Component bootstrapping actions. | ||
*/ | ||
_setup() { | ||
this.uploadDropdown = new Dropdown(this.uploadReportButton); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we move "Dropdown" setup to the initializer then use data-toggle="dropdown"
as a selector? So we don't need to initialize this in every screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really follow, don't we still need to initialize on each screen there's a drop-down anyways? Since this JS file is related to the dashboard screen only. 🤔
I've removed the dashboard component and move the setup here in 81b96cb,
but I'm also thinking we could also do something like we could export some default class selector from the Dropdown component as well.
I'm fine with either, what do you think? @hanam1ni
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can check Initializers
in this convention so we only need a single file to initialize the application-wide component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I gotcha. I've done that in 019de1b 👍
fe21644
to
81b96cb
Compare
4914326
to
1fb6d17
Compare
1fb6d17
to
019de1b
Compare
Closes #17
What happened
✅: Hide the
upload report form
until the user clicks on the button.✅: Minor touchup on buttons
✅: Put eslint in the project and in codebase check.
Insight
Used the dropdown library from bootstrap.
I ran into issues running feature tests on local. Updated my local chromedriver by updating the npm package
chromedriver
in my global packages to the latest version90.0.44
Proof Of Work
Swapped the colors of the buttons in
report.show