Select asset files recursively #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also for the format, I am just curious, is JS .filter work for the object as well ? |
|
I don’t think .filter works with an object. Because I’ve tried to write a unit test for .format() in index.js and it break on this function. |
|
@gatukgl ah okay.. no wonder.. will solve that once I have time.. because I didnt have much time to solve the format and search.. |
|
@hanstf This is working great, great implementation. Project is also getting transpiled with es2015. So you can go back and do syntax changes if you like. Thank you so much! |
This was referenced Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi this is my implementation of the recursive assets selection. I tried to implement the second approach as it seems cleaner than the first one.
Unfortunately I have no time to modify the search and the format. Speaking of search, if let say there are 2 same files in different folder how are we going to handle ? show it in array ?