Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version checking logic #5

Closed
btkelly opened this issue Jan 18, 2016 · 7 comments
Closed

Add version checking logic #5

btkelly opened this issue Jan 18, 2016 · 7 comments

Comments

@btkelly
Copy link
Owner

btkelly commented Jan 18, 2016

The library should be able to look at various forms of version strings or version codes and deduce which version is higher / lower. This will involve major and minor numbers, ex "1.2.1 vs 1.3.0" and "1.5 vs 2.1" as well as a version code that may be only an integer. The consumer should be able to configure what the library is evaluating, the version name or the version code.

@macklinu
Copy link
Collaborator

This library might be useful to us: https://github.com/zafarkhaja/jsemver

@jsibbold
Copy link
Collaborator

For 1.0, we'll be using the version code exclusively, as it is required to be both an integer, and to be higher than the previous.

@stkent
Copy link
Collaborator

stkent commented Jan 18, 2016

Should this be assigned to a different milestone then? 2.0?

@btkelly
Copy link
Owner Author

btkelly commented Jan 18, 2016

I think we should just close it for now, might be better to stick with the version code. Thoughts?

@stkent
Copy link
Collaborator

stkent commented Jan 18, 2016

Do we care about the iOS implementation, and matching that?

@btkelly
Copy link
Owner Author

btkelly commented Jan 18, 2016

They have a build number, we were thinking we should use that for iOS

@stkent
Copy link
Collaborator

stkent commented Jan 18, 2016

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants