-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version checking logic #5
Comments
This library might be useful to us: https://github.com/zafarkhaja/jsemver |
For 1.0, we'll be using the version code exclusively, as it is required to be both an integer, and to be higher than the previous. |
Should this be assigned to a different milestone then? 2.0? |
I think we should just close it for now, might be better to stick with the version code. Thoughts? |
Do we care about the iOS implementation, and matching that? |
They have a build number, we were thinking we should use that for iOS |
Sounds good! |
The library should be able to look at various forms of version strings or version codes and deduce which version is higher / lower. This will involve major and minor numbers, ex "1.2.1 vs 1.3.0" and "1.5 vs 2.1" as well as a version code that may be only an integer. The consumer should be able to configure what the library is evaluating, the version name or the version code.
The text was updated successfully, but these errors were encountered: