Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileClient issues flush() after each single data command store #93

Closed
jbachorik opened this issue Sep 6, 2014 · 1 comment
Closed

FileClient issues flush() after each single data command store #93

jbachorik opened this issue Sep 6, 2014 · 1 comment
Assignees
@jbachorik
Labels
Core perf unr
Milestone
1.3

Comments

@jbachorik
Copy link
Collaborator

FileClient is used when running BTrace via -javaagent option and basically redirects all the output generated by **BTraceUtils.println()" etc. into the file log.

Currently each file write will issue flush() on the associated stream and this creates a huge bottleneck.
@jbachorik jbachorik self-assigned this Sep 6, 2014
@jbachorik jbachorik added this to the 1.3 milestone Sep 6, 2014
@jbachorik
Copy link
Collaborator Author

The solution is to add a flush timer which will flush the stream periodically.

By default the flush will be performed each 5 seconds but this interval is configurable via com.sun.btrace.FileClient.flush system property.

mfilser added a commit to mfilser/btrace that referenced this issue Aug 6, 2015
@mfilser
Fixes a introduced Bug of btraceio#93, make sure to flush the PrintWr…
937a51e 
…iter if the jvm ends
@mfilser mfilser mentioned this issue Aug 18, 2015
Merged
mfilser added a commit to mfilser/btrace that referenced this issue Aug 28, 2015
@mfilser
Fixes btraceio#136 and a introduced Bug of btraceio#93 - make sure th…
22311e7 
…e BTrace Runtime is stopped before exitting the jvm

- no client is connected, only the agent with a script
- make sure the PrintWriter is always flushed after printing with GridDataCommand
mfilser added a commit to mfilser/btrace that referenced this issue Aug 28, 2015
@mfilser
Fixes btraceio#136 and a introduced Bug of btraceio#93 - make sure th…
989f4b0 
…e BTrace Runtime is stopped before exitting the jvm

- no client is connected, only the agent with a script
- make sure the PrintWriter is always flushed after printing with GridDataCommand
jbachorik pushed a commit that referenced this issue Nov 7, 2015
@mfilser @jbachorik
Fixes #136 and a introduced Bug of #93 - make sure the BTrace Runtime…
11c9a28 
… is stopped before exitting the jvm

- no client is connected, only the agent with a script
- make sure the PrintWriter is always flushed after printing with GridDataCommand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbachorik jbachorik

Labels
Core perf unr
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
1 participant
@jbachorik