Improved shared methods #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ik/btrace into improved-shared-methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this patch is to improve shared method handling in BTrace probes.
Currently, the shared methods are limited to allowing only argument types which have been loaded by the bootstrap class loader. This is showing to be very limiting.
At least the shared methods reachable only from
@OnMethodor@OnProbehandlers do not need this limitation because any types visible to the probed method will be visible to the handler code as well.For other handlers this limitation will have to be kept, until a duck-typing equivalent is implemented in BTrace.
As a side effect, the amount of code copied over to the probed method will usually decrease and lighten the pressure on PermGen/Metaspace.
