Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when time series includes nan values #40

Merged
merged 8 commits into from Aug 8, 2023

Conversation

btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Jul 13, 2023

Summary

As the linked issue describes - the tool was not able to process time series containing only nan values. This PR fixes that.

@btschwertfeger btschwertfeger added the Bug Something isn't working label Jul 13, 2023
@btschwertfeger btschwertfeger self-assigned this Jul 13, 2023
@btschwertfeger btschwertfeger added this to the v1.0.3 milestone Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #40 (7fac5db) into master (095f052) will decrease coverage by 0.77%.
The diff coverage is 93.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   99.14%   98.38%   -0.77%     
==========================================
  Files           1        1              
  Lines         235      247      +12     
==========================================
+ Hits          233      243      +10     
- Misses          2        4       +2     
Flag Coverage Δ
unittests 98.38% <93.75%> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmethods/__init__.py 98.38% <93.75%> (-0.77%) ⬇️

@btschwertfeger btschwertfeger changed the title fix error when time series includes nan values Fix error when time series includes nan values Aug 8, 2023
@btschwertfeger btschwertfeger merged commit 95b9105 into master Aug 8, 2023
29 checks passed
@btschwertfeger btschwertfeger deleted the ensure-nan-adjustment branch August 8, 2023 17:27
@btschwertfeger btschwertfeger modified the milestones: v1.0.3, v1.0.4 Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The tool fails when input time series include np.nan for distribution-based methods
1 participant