Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type checking for parameters of bias correction techniques #43

Merged
merged 5 commits into from Aug 9, 2023

Conversation

btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Aug 8, 2023

Since I got to many E-Mails about "this does not work" and "how should the data look like" I decided to add some TypeErrors to notify users that they need to have lists or xarray.**.DataArrays for some input data.

@btschwertfeger btschwertfeger added this to the Next Release milestone Aug 8, 2023
@btschwertfeger btschwertfeger self-assigned this Aug 8, 2023
@btschwertfeger btschwertfeger linked an issue Aug 8, 2023 that may be closed by this pull request
@btschwertfeger btschwertfeger modified the milestones: Upcoming Release, v1.0.4, v1.0.3 Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #43 (009f292) into master (cca3ead) will decrease coverage by 0.15%.
The diff coverage is 92.85%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   98.38%   98.23%   -0.15%     
==========================================
  Files           1        1              
  Lines         247      283      +36     
==========================================
+ Hits          243      278      +35     
- Misses          4        5       +1     
Flag Coverage Δ
unittests 98.23% <92.85%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmethods/__init__.py 98.23% <92.85%> (-0.15%) ⬇️

@btschwertfeger btschwertfeger marked this pull request as ready for review August 9, 2023 13:12
@btschwertfeger btschwertfeger merged commit 9878005 into master Aug 9, 2023
29 checks passed
@btschwertfeger btschwertfeger deleted the 42-validate-types-during-runtime branch August 9, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate types during runtime
1 participant